Error SMTP_MAX_SENDS after last update

[fabiotpr]

After last svn update I did this error message sendi emails:

Fatal error: Undefined class constant 'SMTP_MAX_SENDS'
in /var/www/cerb4/libs/devblocks/api/Engine.php on line 718

This is my svn info:

root@cerb4:/var/www/cerb4# svn info
Percorso: .
URL: http://svn.webgroupmedia.com/cerb4/tags/stable
Repository: http://svn.webgroupmedia.com/cerb4
UUID del Repository: 58cff151-b722-0410-b014-f78a459f8f02
Revisione: 634
Tipo di Nodo: directory
Azione: normale
Autore dell'Ultimo Cambiamento: jstanden
Revisione dell'Ultimo Cambiamento: 624
Data dell'Ultimo Cambiamento: 2008-06-11 08:04:35 +0200 (mer, 11 giu 2008)


Let me know.

f.

[dfroberg]

SMTP_MAX_SENDS

Same here.... last stable build.

[Hildy]

Hrm. I don't think 634 was supposed to be merged into the stable branch, as it was just checked in over the weekend and QA hasn't had time to look at it.

That said, the SMTP_MAX_SENDS is a new value to control how many emails will be sent per SMTP connection. Check your mail settings, I've a slight suspicion it may cause problems if it's never been set.

[Hildy]

Update: I'm not able to reproduce this here... Does setting it manually help (in Helpdesk Setup -> Mail Servers)?

[fabiotpr]

I don't see any MAX_SENDS option in Helpdesk Setup -> Mail Servers.
I've tried to comment out the line in Engine.php and now email are sent.

f.

[Hildy]

Helpdesk Setup -> Mail Servers -> Outgoing Mail Preferences -> Maximum Deliveries Per SMTP Connection:

If that option isn't there, you've got an incomplete update.

[Hildy]

Eh. It seems that the devblocks stuff hit stable while the rest of the cerb4 stuff is still in the dev branch. We'll get that taken care of.

[Hildy]

The change to devblocks has been rolled back out of stable, so if you update again, it should fix things.

The short version is that there should never be anything in devblocks tied to any of the apps that use it, but the mail code was dependant on Cerb4, and some of those changes over the weekend caused this problem.

[dfroberg]

This is getting a tad silly...

Read the above and svn updated and now I get;

Parse error: syntax error, unexpected T_SL in /var/www/cerb4/libs/devblocks/api/Engine.php on line 699

Kablowie one dead helpdesk...

[dfroberg]

This is getting a tad silly...

Read the above and svn updated and now I get;

Parse error: syntax error, unexpected T_SL in /var/www/cerb4/libs/devblocks/api/Engine.php on line 699

Kablowie one dead helpdesk...

Deleting the file and redoing the svn up
resolved it apparently there was some kind of merge conflict.

[fabiotpr]

Also after deleting and redoing svn for files involved, I get this error sending emails:

Warning: Missing argument 1 for _DevblocksEmailManager::getMailer(),
called in /var/www/cerb4/api/app/Mail.php on line 147 and defined in
/var/www/cerb4/libs/devblocks/api/Engine.php on line 701

Warning: Cannot modify header information - headers already sent by
(output started at /var/www/cerb4/libs/devblocks/api/Engine.php:701)
in /var/www/cerb4/libs/devblocks/Devblocks.class.php on line 841


When I try to do a SMTP Test in HelpDesk Setup -> Mail Server I get this error:

SMTP Connection Failed: The SMTP connection failed to start [s:0]:
fsockopen returned Error Number 0 and Error String 'Failed to
parse address "s"'

"s" is the first letter in my smtp setting....

Emails seems to be correctly sent.

This is my "svn status"

root@cerb4:/var/www/cerb4# svn status
? support
M framework.config.php
X libs/devblocks
M api/app/Parser.php
M api/Application.class.php
M .htaccess-dist

Esecuzione di status sull'elemento esterno in 'libs/devblocks'
? libs/devblocks/libs/ZendFramework


f.

[Hildy]

fabiotpr, What's the output of `svn info`? You can also delete the entire libs/devblocks directory and svn update to get it back (there might be some funny conflicts).

[fabiotpr]

This is svn info output:

root@cerb4:/var/www/cerb4# svn info
Percorso: .
URL: http://svn.webgroupmedia.com/cerb4/tags/stable
Repository: http://svn.webgroupmedia.com/cerb4
UUID del Repository: 58cff151-b722-0410-b014-f78a459f8f02
Revisione: 639
Tipo di Nodo: directory
Azione: normale
Autore dell'Ultimo Cambiamento: jstanden
Revisione dell'Ultimo Cambiamento: 624
Data dell'Ultimo Cambiamento: 2008-06-11 08:04:35 +0200 (mer, 11 giu 2008)

Deleting all libs/devblocks did not solved

f.

[Hildy]

What's the diff on Parser and Application?

[fabiotpr]

root@cerb4:/var/www/cerb4# svn diff api/app/Parser.php
Index: api/app/Parser.php
================================================== =================
--- api/app/Parser.php (revisione 639)
+++ api/app/Parser.php (copia locale)
@@ -851,6 +851,9 @@
@$aXEnvelopeTo = imap_rfc822_parse_adrlist($headers['x-envelope-to'],'localhost');
if(!is_array($aXEnvelopeTo)) $aXEnvelopeTo = array($aXEnvelopeTo);
}
+
+// Commento di Fabio http://www.cerb4.com/forums/showthread.php?t=355
+
if(isset($headers['delivered-to'])) {
@$aDeliveredTo = imap_rfc822_parse_adrlist($headers['delivered-to'],'localhost');
if(!is_array($aDeliveredTo)) $aDeliveredTo = array($aDeliveredTo);



root@cerb4:/var/www/cerb4# svn diff api/Application.class.php
Index: api/Application.class.php
================================================== =================
--- api/Application.class.php (revisione 639)
+++ api/Application.class.php (copia locale)
@@ -344,7 +344,7 @@
*
* @return a unique ticket mask as a string
*/
- static function generateTicketMask($pattern = "LLL-NNNNN-NNN") {
+ static function generateTicketMask($pattern = "YMD-LLL") {
$letters = "ABCDEFGHIJKLMNPQRSTUVWXYZ";
$numbers = "123456789";


f.

[jstanden]

We really should make the ticket mask pattern a group/global option. It made sense that people would edit the code during the beta, but that's not necessary now.

I assigned the feature request to myself:
http://www.wgmdev.com/jira/browse/CHD-622

[fabiotpr]

Ok Jeff,
but have you any suggestion to solve this problem ?

f.

[jstanden]

You shouldn't still be getting the getMailer() error if your Devblocks rolled back to stable properly.

What do you get for 'svn info' from your /cerb4/libs/devblocks directory? Try a 'svn up' in that directory.

[fabiotpr]

root@cerb4:/var/www/cerb4/libs/devblocks# svn info
Percorso: .
URL: http://svn.webgroupmedia.com/devblocks/devblocks
Repository: http://svn.webgroupmedia.com/devblocks
UUID del Repository: 747e5740-6425-0410-825b-f4fe3d30fc61
Revisione: 228
Tipo di Nodo: directory
Azione: normale
Autore dell'Ultimo Cambiamento: jstanden
Revisione dell'Ultimo Cambiamento: 228
Data dell'Ultimo Cambiamento: 2008-06-24 01:56:55 +0200 (mar, 24 giu 2008)

root@cerb4:/var/www/cerb4/libs/devblocks# svn up
Alla revisione 228.

f.

[fabiotpr]

Ok, solved with this:

root@cerb4:/var/www/cerb4/libs/devblocks# svn switch http://svn.webgroupmedia.com/devblocks/branches/stable/

f.

[fabiotpr]

How can I apply this switch for devblocks permanently?
When I do "svn up" in root directory of cerb4 the repository of devblocks backs to http://svn.webgroupmedia.com/devblocks/ instead of stable directory

f.

[Hildy]

You want to use svn switch --relocate... more instructions here: http://wiki.cerb4.com/wiki/Changing_SVN_Repository_Locations

[jstanden]

You shouldn't have to "svn switch" in the Devblocks directory. Devblocks is linked to Cerb4 through an external repository.

At the shell, in your /cerb4/ directory, type:
svn pget svn:externals

You should see the /cerb4/branches/stable linked to /devblocks/branches/stable -- and /cerb4/cerb4 is linked to /devblocks/devblocks (for development versions).

[fabiotpr]

I don't. I've only this (wrong) output:

root@cerb4:/var/www/cerb4# svn pget svn:externals
libs/devblocks http://svn.webgroupmedia.com/devblocks/devblocks

Let me know.

f.

[jstanden]

Type this from the same dir:
svn info

[fabiotpr]

Here:

root@cerb4:/var/www/cerb4# svn info
Percorso: .
URL: http://svn.webgroupmedia.com/cerb4/tags/stable
Repository: http://svn.webgroupmedia.com/cerb4
UUID del Repository: 58cff151-b722-0410-b014-f78a459f8f02
Revisione: 639
Tipo di Nodo: directory
Azione: normale
Autore dell'Ultimo Cambiamento: jstanden
Revisione dell'Ultimo Cambiamento: 624
Data dell'Ultimo Cambiamento: 2008-06-11 08:04:35 +0200 (mer, 11 giu 2008)

f.

[fabiotpr]

Hello,
is my *svn info* wrong?

f.

[jstanden]

Hey Fabio,

It looks fine. It's still strange your Devblocks isn't locked to stable since the Cerb4 stable branch is. Unless you changed it locally.

From your /cerb4/ directory, you could type:
rm -Rf libs/devblocks
svn up && rm -Rf install/

That should do a fresh checkout of the external repository.

[fabiotpr]

Ok, but now I get this error sending emails:

Warning: Missing argument 1 for _DevblocksEmailManager::getMailer(), called in /var/www/cerb4/api/app/Mail.php on line 147 and defined in /var/www/cerb4/libs/devblocks/api/Engine.php on line 701

Warning: Cannot modify header information - headers already sent by (output started at /var/www/cerb4/libs/devblocks/api/Engine.php:701) in /var/www/cerb4/libs/devblocks/Devblocks.class.php on line 841

But emails are correcty sent.

f.

[jstanden]

It doesn't make sense that you'd still be getting that error when using the 'stable' branch. It sounds like your Cerb4 and Devblocks repositories are still out-of-sync.

The best thing you can really do at this point is to do a completely clean checkout. Copy the DB_* values from your framework.config.php into the new file. Copy your /storage/ directory over.

This really isn't a code or repository issue.

[fabiotpr]

Ok, solved in this way.
Thanks.

f.

[jstanden]

Excellent. Glad to hear it. :)